Skip to content

Conversation

workingjubilee
Copy link
Member

I made a mistake in assuming there would be a twin for every version of the upload/download artifact changes. There are very not. Alternatively, we can use v4.1.8 for download-artifact and v4.4.0 for upload-artifact.

Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There's no reason we need to pin to a specific minor version.

@ChrisDenton ChrisDenton merged commit 0b91167 into rust-lang:master Sep 14, 2024
39 of 41 checks passed
@workingjubilee
Copy link
Member Author

For future reference, these "fuzzy" versions are actually quite exact, no version resolution happens except via Git. Instead, GitHub simply uses a tag for each, e.g. these two tags are currently the same commit:

@workingjubilee workingjubilee deleted the prefer-lossier-version-specs branch September 14, 2024 22:46
@workingjubilee
Copy link
Member Author

Ugh, fixing this has not been enough to restore the workflow to functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants